[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Probing Meson for build configurations (was: [PATCH v2 3/6] tests/accept

From: Wainer dos Santos Moschetta
Subject: Probing Meson for build configurations (was: [PATCH v2 3/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test)
Date: Mon, 22 Feb 2021 12:44:37 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

Hi Paolo,

Last week I was chatting with Cleber about probing configured features so that tests could be skipped (just like on this case). He has a implementation which never landed in, and is based on the old build system. Now with Meson, I am wondering if it has some sort of API for probing, or parsing the JSON files in build/meson-info/ is the proper way to inspect the build configuration.


- Wainer

On 2/22/21 7:14 AM, Alex Bennée wrote:
This is a band-aid with a TODO for cases when QEMU doesn't start due
to missing VirGL. Longer term we could do with some proper feature

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210217121932.19986-7-alex.bennee@linaro.org>
  tests/acceptance/virtio-gpu.py | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py
index ab1a4c1a71..ab18cddbb7 100644
--- a/tests/acceptance/virtio-gpu.py
+++ b/tests/acceptance/virtio-gpu.py
@@ -85,7 +85,12 @@ def test_virtio_vga_virgl(self):
-        self.vm.launch()
+        try:
+            self.vm.launch()
+        except:
+            # TODO: probably fails because we are missing the VirGL features
+            self.cancel("VirGL not enabled?")
          self.wait_for_console_pattern("as init process")
              self, "/usr/sbin/modprobe virtio_gpu", ""

reply via email to

[Prev in Thread] Current Thread [Next in Thread]