[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/3] scripts/ci/gitlab-pipeline-status: split utlity function for
From: |
Cleber Rosa |
Subject: |
[PATCH 1/3] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET |
Date: |
Mon, 22 Feb 2021 14:32:38 -0500 |
This simply splits out the code that does an HTTP GET so that it
can be used for other API requests.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/scripts/ci/gitlab-pipeline-status
b/scripts/ci/gitlab-pipeline-status
index 78e72f6008..0c1e8bd8a7 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -48,18 +48,25 @@ def get_local_branch_commit(branch):
return result
-def get_pipeline_status(project_id, commit_sha1):
+def get_json_http_response(url):
"""
- Returns the JSON content of the pipeline status API response
+ Returns the JSON content of an HTTP GET request to gitlab.com
"""
- url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
- commit_sha1)
connection = http.client.HTTPSConnection('gitlab.com')
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
raise CommunicationFailure("Failed to receive a successful response")
- json_response = json.loads(response.read())
+ return json.loads(response.read())
+
+
+def get_pipeline_status(project_id, commit_sha1):
+ """
+ Returns the JSON content of the pipeline status API response
+ """
+ url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
+ commit_sha1)
+ json_response = get_json_http_response(url)
# As far as I can tell, there should be only one pipeline for the same
# project + commit. If this assumption is false, we can add further
--
2.25.4