[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] scripts/ci/gitlab-pipeline-status: give more information

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 2/3] scripts/ci/gitlab-pipeline-status: give more information on failures
Date: Tue, 23 Feb 2021 11:40:21 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/22/21 4:32 PM, Cleber Rosa wrote:
When an HTTP GET request fails, it's useful to go beyond the "not
successful" message, and show the code returned by the server.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  scripts/ci/gitlab-pipeline-status | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

diff --git a/scripts/ci/gitlab-pipeline-status 
index 0c1e8bd8a7..ad62ab3cfc 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -56,7 +56,9 @@ def get_json_http_response(url):
      connection.request('GET', url=url)
      response = connection.getresponse()
      if response.code != http.HTTPStatus.OK:
-        raise CommunicationFailure("Failed to receive a successful response")
+        msg = "Received unsuccessful response: %s (%s)" % (response.code,
+                                                           response.reason)
+        raise CommunicationFailure(msg)
      return json.loads(response.read())

reply via email to

[Prev in Thread] Current Thread [Next in Thread]