[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/16] qapi/expr.py: move string check upwards in check_type
From: |
John Snow |
Subject: |
[PATCH v3 05/16] qapi/expr.py: move string check upwards in check_type |
Date: |
Mon, 22 Feb 2021 19:33:57 -0500 |
For readability purposes only, shimmy the early return upwards to the
top of the function, so cases proceed in order from least to most
complex.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
scripts/qapi/expr.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 138fab0711f..c97e8ce8a4d 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -150,6 +150,10 @@ def check_type(value, info, source,
if value is None:
return
+ # Type name
+ if isinstance(value, str):
+ return
+
# Array type
if isinstance(value, list):
if not allow_array:
@@ -160,10 +164,6 @@ def check_type(value, info, source,
source)
return
- # Type name
- if isinstance(value, str):
- return
-
# Anonymous type
if not allow_dict:
--
2.29.2
- Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict, (continued)
[PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict', John Snow, 2021/02/22
[PATCH v3 03/16] qapi/expr.py: constrain incoming expression types, John Snow, 2021/02/22
[PATCH v3 05/16] qapi/expr.py: move string check upwards in check_type,
John Snow <=
[PATCH v3 06/16] qapi/expr.py: Check type of 'data' member, John Snow, 2021/02/22
[PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/02/22
[PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/02/22