qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qtest: delete redundant qtest.h header files


From: Markus Armbruster
Subject: Re: [PATCH] qtest: delete redundant qtest.h header files
Date: Thu, 25 Feb 2021 10:08:29 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Chen Qun <kuhn.chenqun@huawei.com> writes:

> There are 23 files that include the "sysemu/qtest.h",
> but they do not use any qtest functions.
>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>

The subject sounds as if you were deleting file include/sysemu/qtest.h,
which would be wrong.  You're actually deleting inclusions.  Suggest to
say

    qtest: delete superfluous inclusions of qtest.h

or

    delete superfluous #include "sysemu/qtest.h"

Perhaps the maintainer merging your patch can do that for you.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]