[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse |
|
Date: |
Fri, 26 Feb 2021 18:46:41 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/26/21 6:08 PM, Paolo Bonzini wrote:
> This enables some simplification of vl.c via error_fatal, and improves
> error messages. Before:
>
> Before:
> $ ./qemu-system-x86_64 -readconfig .
> qemu-system-x86_64: error reading file
> qemu-system-x86_64: -readconfig .: read config .: Invalid argument
> $ /usr/libexec/qemu-kvm -readconfig foo
> qemu-kvm: -readconfig foo: read config foo: No such file or directory
>
> After:
>
> $ ./qemu-system-x86_64 -readconfig .
> qemu-system-x86_64: -readconfig .: error reading file: Is a directory
> $ ./qemu-system-x86_64 -readconfig foo
> qemu-system-x86_64: -readconfig foo: Cannot read config file foo: No such
> file or directory
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/blkdebug.c | 3 +--
> include/qemu/config-file.h | 5 +++--
> softmmu/vl.c | 29 +++++++++++------------------
> util/qemu-config.c | 23 ++++++++++++-----------
> 4 files changed, 27 insertions(+), 33 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>