qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v16 09/99] qtest/bios-tables-test: Rename tests not TCG speci


From: Thomas Huth
Subject: Re: [PATCH v16 09/99] qtest/bios-tables-test: Rename tests not TCG specific
Date: Mon, 7 Jun 2021 15:39:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0

On 04/06/2021 17.51, Alex Bennée wrote:
From: Philippe Mathieu-Daudé <philmd@redhat.com>

Various tests don't require TCG, but have '_tcg' in their name.
As this is misleading, remove 'tcg' from their name.

Reported-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210505125806.1263441-10-philmd@redhat.com>
---
  tests/qtest/bios-tables-test.c | 142 ++++++++++++++++-----------------
  1 file changed, 71 insertions(+), 71 deletions(-)
[...]
@@ -1255,7 +1255,7 @@ static void test_acpi_microvm_rtc_tcg(void)
      free_test_data(&data);
  }
-static void test_acpi_microvm_pcie_tcg(void)
+static void test_acpi_microvm_pcie(void)
  {
      test_data data;

This change is wrong: test_acpi_microvm_pcie_tcg() uses data.tcg_only = true, so the _tcg suffix indeed makes sense here.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]