[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 09/99] qtest/bios-tables-test: Rename tests not TCG speci
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v16 09/99] qtest/bios-tables-test: Rename tests not TCG specific |
Date: |
Tue, 8 Jun 2021 10:33:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/7/21 3:39 PM, Thomas Huth wrote:
> On 04/06/2021 17.51, Alex Bennée wrote:
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>> Various tests don't require TCG, but have '_tcg' in their name.
>> As this is misleading, remove 'tcg' from their name.
>>
>> Reported-by: Igor Mammedov <imammedo@redhat.com>
>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20210505125806.1263441-10-philmd@redhat.com>
>> ---
>> tests/qtest/bios-tables-test.c | 142 ++++++++++++++++-----------------
>> 1 file changed, 71 insertions(+), 71 deletions(-)
> [...]
>> @@ -1255,7 +1255,7 @@ static void test_acpi_microvm_rtc_tcg(void)
>> free_test_data(&data);
>> }
>> -static void test_acpi_microvm_pcie_tcg(void)
>> +static void test_acpi_microvm_pcie(void)
>> {
>> test_data data;
>
> This change is wrong: test_acpi_microvm_pcie_tcg() uses data.tcg_only =
> true, so the _tcg suffix indeed makes sense here.
I supposed I messed while rebasing...
- Re: [PATCH v16 08/99] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64, (continued)
- [PATCH v16 07/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG, Alex Bennée, 2021/06/04
- [PATCH v16 06/99] qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests, Alex Bennée, 2021/06/04
- [PATCH v16 09/99] qtest/bios-tables-test: Rename tests not TCG specific, Alex Bennée, 2021/06/04
- [PATCH v16 11/99] qtest/bios-tables-test: Make test build-independent from accelerator, Alex Bennée, 2021/06/04
- [PATCH v16 12/99] qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore, Alex Bennée, 2021/06/04
- [PATCH v16 13/99] meson: add target_user_arch, Alex Bennée, 2021/06/04
- [PATCH v16 10/99] qtest/bios-tables-test: Rename TCG specific tests, Alex Bennée, 2021/06/04