[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 21/42] scripts/qmp-shell: remove prompt argument from read_exec_c
From: |
John Snow |
Subject: |
[PATCH 21/42] scripts/qmp-shell: remove prompt argument from read_exec_command |
Date: |
Mon, 7 Jun 2021 16:06:28 -0400 |
It's only ever used by one caller, we can just absorb that logic.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qmp/qmp-shell | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index 3b86ef7d88..31269859c4 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -298,14 +298,14 @@ class QMPShell(qmp.QEMUMonitorProtocol):
return 'TRANS> '
return '(QEMU) '
- def read_exec_command(self, prompt):
+ def read_exec_command(self):
"""
Read and execute a command.
@return True if execution was ok, return False if disconnected.
"""
try:
- cmdline = input(prompt)
+ cmdline = input(self.prompt)
except EOFError:
print()
return False
@@ -436,7 +436,7 @@ def main():
die(f"Couldn't connect to {args.qmp_server}: {err!s}")
qemu.show_banner()
- while qemu.read_exec_command(qemu.prompt):
+ while qemu.read_exec_command():
pass
qemu.close()
--
2.31.1
- [PATCH 00/42] python: move qmp-shell into qemu.qmp package, John Snow, 2021/06/07
- [PATCH 02/42] scripts/qmp-shell: Apply flake8 rules, John Snow, 2021/06/07
- [PATCH 12/42] scripts/qmp-shell: make QMPCompleter returns explicit, John Snow, 2021/06/07
- [PATCH 05/42] scripts/qmp-shell: fix connect method signature, John Snow, 2021/06/07
- [PATCH 01/42] scripts/qmp-shell: apply isort rules, John Snow, 2021/06/07
- [PATCH 04/42] scripts/qmp-shell: fix exception handling, John Snow, 2021/06/07
- [PATCH 06/42] scripts/qmp-shell: remove shadowed variable from _print(), John Snow, 2021/06/07
- [PATCH 07/42] scripts/qmp-shell: use @classmethod where appropriate, John Snow, 2021/06/07
- [PATCH 03/42] scripts/qmp-shell: fix show_banner signature, John Snow, 2021/06/07
- [PATCH 21/42] scripts/qmp-shell: remove prompt argument from read_exec_command,
John Snow <=
- [PATCH 08/42] scripts/qmp-shell: Use python3-style super(), John Snow, 2021/06/07
- [PATCH 11/42] scripts/qmp-shell: ignore visit_Name name, John Snow, 2021/06/07
- [PATCH 09/42] scripts/qmp-shell: declare verbose in __init__, John Snow, 2021/06/07
- [PATCH 14/42] scripts/qmp-shell: fix shell history exception handling, John Snow, 2021/06/07
- [PATCH 20/42] scripts/qmp-shell: move get_prompt() to prompt property, John Snow, 2021/06/07
- [PATCH 10/42] scripts/qmp-shell: use triple-double-quote docstring style, John Snow, 2021/06/07
- [PATCH 18/42] scripts/qmp-shell: Add pretty attribute to HMP shell, John Snow, 2021/06/07
- [PATCH 15/42] scripts/qmp-shell: remove if-raise-else patterns, John Snow, 2021/06/07
- [PATCH 29/42] scripts/qmp-shell: unprivatize 'pretty' property, John Snow, 2021/06/07
- [PATCH 19/42] scripts/qmp-shell: Make verbose a public attribute, John Snow, 2021/06/07