qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machin


From: Richard Henderson
Subject: Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine
Date: Tue, 8 Jun 2021 08:45:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/8/21 4:55 AM, Alex Bennée wrote:
+    tcg_init(s->tb_size * 1024 * 1024, s->splitwx_enabled);
+

nit: you could clean up to use unit.h definitions, i.e. tb->size * MiB

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Amusingly, I cleaned that up this week while rebasing.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]