Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

[Richard Henderson]

On 6/9/21 7:58 AM, Luis Fernando Fujita Pires wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
> > There is only one caller, and shortly we will need access to the MachineState,
> > which tcg_init_machine already has.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   accel/tcg/internal.h      |  2 ++
> >   include/sysemu/tcg.h      |  2 --
> >   accel/tcg/tcg-all.c       | 14 +++++++++++++-
> >   accel/tcg/translate-all.c | 21 ++-------------------
> >   4 files changed, 17 insertions(+), 22 deletions(-)
>
> Nitpicking: there's a comment in bsd-user/main.c's main() that should be 
> updated now that tcg_exec_init() no longer exists. Currently:
> 934     /*
> 935      * Now that page sizes are configured in tcg_exec_init() we can do
> 936      * proper page alignment for guest_base.
> 937      */
> 938     guest_base = HOST_PAGE_ALIGN(guest_base);

Thanks.  I think the comment was wrong, and has been wrong for a while.  The 
only thing that controls HOST_PAGE_ALIGN is command-line options.

I've just clipped tcg_exec_init out of the comment and will leave the rest to 
the guys that are modernizing bsd-user/.


r~