Re: [PATCH 07/11] machine: move common smp_parse code to caller

[Daniel P . Berrangé]

On Thu, Jun 10, 2021 at 03:35:34PM +0200, Paolo Bonzini wrote:
> Most of smp_parse and pc_smp_parse is guarded by an "if (opts)"
> conditional, and the rest is common to both function.  Move the
> conditional and the common code to the caller, machine_smp_parse.
> 
> Move the replay_add_blocker call after all errors are checked for.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/core/machine.c | 112 ++++++++++++++++++++++----------------------
>  hw/i386/pc.c      | 116 +++++++++++++++++++++-------------------------
>  2 files changed, 110 insertions(+), 118 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|