qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/11] keyval: introduce keyval_parse_into


From: Paolo Bonzini
Subject: Re: [PATCH 03/11] keyval: introduce keyval_parse_into
Date: Wed, 16 Jun 2021 20:05:19 +0200



Il mer 16 giu 2021, 16:09 Markus Armbruster <armbru@redhat.com> ha scritto:
Paolo Bonzini <pbonzini@redhat.com> writes:

> Allow parsing multiple keyval sequences into the same dictionary.
> This will be used to simplify the parsing of the -M command line
> option, which is currently a .merge_lists = true QemuOpts group.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Straightforward.  Thanks for adjusting the contract for
keyval_parse_into().

Reviewed-by: Markus Armbruster <armbru@redhat.com>

It's too hot & humid for me to figure out why you need both
keyval_merge() and keyval_parse_into().

I don't need both, but I do need keyval_merge() which is the complex one; and keyval_parse_into() is straightforward enough to be worth the simpler code in vl.c.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]