[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 24/27] Revert "tcg/tci: Use exec/cpu_ldst.h interfaces"
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v7 24/27] Revert "tcg/tci: Use exec/cpu_ldst.h interfaces" |
Date: |
Sat, 12 Jun 2021 11:24:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/1/21 5:01 PM, Richard Henderson wrote:
> This reverts commit dc09f047eddec8f4a1991c4f5f4a428d7aa3f2c0.
>
> For tcg, tracepoints are expanded inline in tcg opcodes.
> Using a helper which generates a second tracepoint is incorrect.
>
> For system mode, the extraction and re-packing of MemOp and mmu_idx
> lost the alignment information from MemOp. So we were no longer
> raising alignment exceptions for !TARGET_ALIGNED_ONLY guests.
> This can be seen in tests/tcg/xtensa/test_load_store.S.
>
> For user mode, we must update to the new signature of g2h() so that
> the revert compiles. We can leave set_helper_retaddr for later.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci.c | 73 ++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 45 insertions(+), 28 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v7 11/27] tcg/tci: Use ffi for calls, (continued)
- [PATCH v7 19/27] tcg/tci: Implement extract, sextract, Richard Henderson, 2021/06/01
- [PATCH v7 17/27] tcg/tci: Implement movcond, Richard Henderson, 2021/06/01
- [PATCH v7 12/27] tcg/tci: Reserve r13 for a temporary, Richard Henderson, 2021/06/01
- [PATCH v7 14/27] tcg/tci: Remove tci_write_reg, Richard Henderson, 2021/06/01
- [PATCH v7 18/27] tcg/tci: Implement andc, orc, eqv, nand, nor, Richard Henderson, 2021/06/01
- [PATCH v7 26/27] tcg/tci: Use {set,clear}_helper_retaddr, Richard Henderson, 2021/06/01
- [PATCH v7 24/27] Revert "tcg/tci: Use exec/cpu_ldst.h interfaces", Richard Henderson, 2021/06/01
- Re: [PATCH v7 24/27] Revert "tcg/tci: Use exec/cpu_ldst.h interfaces",
Philippe Mathieu-Daudé <=
- [PATCH v7 23/27] tcg/tci: Split out tci_qemu_ld, tci_qemu_st, Richard Henderson, 2021/06/01
- [PATCH v7 20/27] tcg/tci: Implement clz, ctz, ctpop, Richard Henderson, 2021/06/01
- Re: [PATCH v7 00/27] TCI fixes and cleanups, no-reply, 2021/06/01
- Re: [PATCH v7 00/27] TCI fixes and cleanups, Philippe Mathieu-Daudé, 2021/06/19