Re: [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"

[Hyman Huang]

在 2021/6/3 22:20, huangy81@chinatelecom.cn 写道:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> migrate-set-parameters parse "downtime_limit" as integer type when
> execute "migrate-set-parameters" before migration, and, the unit
> dowtime_limit is milliseconds, fix this two so that test can go
> smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
>   tests/migration/guestperf/engine.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/migration/guestperf/engine.py 
> b/tests/migration/guestperf/engine.py
> index 9e16fa92d2..7c991c4407 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -153,7 +153,7 @@ def _migrate(self, hardware, scenario, src, dst, 
> connect_uri):
>                              max_bandwidth=scenario._bandwidth * 1024 * 1024)
>   
>           resp = src.command("migrate-set-parameters",
> -                           downtime_limit=scenario._downtime / 1024.0)
> +                           downtime_limit=scenario._downtime)
>   
>           if scenario._compression_mt:
>               resp = src.command("migrate-set-capabilities",
- ping

this patch fix the downtime_limit setting when guestperf start 
migration, qemu can not accept down_time parameter with float type. when 
running guestperf to test migration, it'll report error.
i think it's resonable for apply this patch

please review，thanks, :) !

--
Best regard

Hyman Huang(黄勇)