Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast

[Hyman Huang]

cc original author Daniel P. Berrangé <berrange@redhat.com> :)

may be this two fixes can be squashed into a single patch.

在 2021/6/16 14:26, Hyman Huang 写道:
> 在 2021/6/3 22:19, huangy81@chinatelecom.cn 写道:
> > From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> >
> > thread_id in CpuInfoFast is deprecated, parse thread-id instead
> > after execute qmp query-cpus-fast. fix this so that test can
> > go smoothly.
> >
> > Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> > ---
> >   tests/migration/guestperf/engine.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/migration/guestperf/engine.py 
> > b/tests/migration/guestperf/engine.py
> > index 208e095794..9e16fa92d2 100644
> > --- a/tests/migration/guestperf/engine.py
> > +++ b/tests/migration/guestperf/engine.py
> > @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, 
> > connect_uri):
> >           vcpus = src.command("query-cpus-fast")
> >           src_threads = []
> >           for vcpu in vcpus:
> > -            src_threads.append(vcpu["thread_id"])
> > +            src_threads.append(vcpu["thread-id"])
> >           # XXX how to get dst timings on remote host ?
>
> - ping
>
> this patch fix thread_id so that guestperf can run successfully
>
> please review, thanks : ) !

--
Best regard

Hyman Huang(黄勇)