[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp |
Date: |
Wed, 16 Jun 2021 12:46:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
+Helge
On 6/16/21 3:11 AM, Richard Henderson wrote:
> We cannot use a raw sigtramp page for hppa,
> but must wait for full vdso support.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/hppa/target_signal.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
> index 7f525362e9..d558119ee7 100644
> --- a/linux-user/hppa/target_signal.h
> +++ b/linux-user/hppa/target_signal.h
> @@ -71,4 +71,18 @@ typedef struct target_sigaltstack {
> /* mask for all SS_xxx flags */
> #define TARGET_SS_FLAG_BITS TARGET_SS_AUTODISARM
>
> +/*
> + * We cannot use a bare sigtramp page for hppa-linux.
> + *
> + * Unlike other guests where we use the instructions at PC to validate
> + * an offset from SP, the hppa libgcc signal frame fallback unwinding uses
> + * the PC address itself to find the frame. This is due to the fact that
> + * the hppa grows the stack upward, and the frame is of unknown size.
> + *
> + * TODO: We should be able to use a VDSO to address this, by providing
> + * proper unwind info for the sigtramp code, at which point the fallback
> + * unwinder will not be used.
> + */
> +#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 0
> +
> #endif /* HPPA_TARGET_SIGNAL_H */
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH 04/21] linux-user/arm: Implement setup_sigtramp, (continued)
[PATCH 05/21] linux-user/alpha: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 10/21] linux-user/m68k: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 11/21] linux-user/microblaze: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 06/21] linux-user/cris: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 12/21] linux-user/mips: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 14/21] linux-user/openrisc: Implement setup_sigtramp, Richard Henderson, 2021/06/15