Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

[Richard Henderson]

On 6/16/21 1:07 AM, Taylor Simpson wrote:
> > +    /*
> > +     * The on-stack signal trampoline is no longer executed;
> > +     * however, the libgcc signal frame unwinding code checks
> > +     * for the presence of these two numeric magic values.
> > +     */
>
> Hexagon uses musl, not libgcc.  So, I'm not sure if this is needed.  The 
> signals.c test passes for me without this change.  Are you seeing it fail?

I copied the comment from the kernel source.


> > +void setup_sigtramp(abi_ulong sigtramp_page) {
> > +    uint32_t *tramp = lock_user(VERIFY_WRITE, sigtramp_page, 4 * 2, 0);
> > +    assert(tramp != NULL);
> > +
> > +    default_rt_sigreturn = sigtramp_page;
> > +    install_sigtramp(tramp);
> > +
> > +    unlock_user(tramp, sigtramp_page, 4 * 2); }
>
> Put the closing curly on a new line.

That's your mailer.  It's correct in the original.


r~