[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] target/mips: Restrict some system specific declarations
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu |
Date: |
Sat, 19 Jun 2021 16:44:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/19/21 12:38 AM, Richard Henderson wrote:
> On 6/17/21 10:43 AM, Philippe Mathieu-Daudé wrote:
>> Commit 043715d1e0f ("target/mips: Update ITU to utilize SAARI
>> and SAAR CP0 registers") declared itc_reconfigure() in public
>> namespace, while it is restricted to system emulation.
>>
>> Similarly commit 5679479b9a1 ("target/mips: Move CP0 helpers
>> to sysemu/cp0.c") restricted cpu_mips_soft_irq() definition to
>> system emulation, but forgot to restrict its declaration.
>>
>> Commit a2b0a27d33e ("target/mips: Move TCG source files under
>> tcg/ sub directory") restricted mips_cpu_do_unaligned_access()
>> to system emulation but forgot to guard the declaration.
>
> FWIW, I think the unaligned_access tcg_ops hook should be available for
> user-only as well, like for tlb_fill. That it is sysemu only at the
> moment is a bug that affects user-only atomic access.
OK understood, I'll drop that hunk.
> Anyway,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks!
- [PATCH 1/9] target/mips: Do not abort on invalid instruction, (continued)
- [PATCH 1/9] target/mips: Do not abort on invalid instruction, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 2/9] target/mips: Fix more TCG temporary leaks in gen_pool32a5_nanomips_insn, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 3/9] target/mips: Move TCG trace events to tcg/ sub directory, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 4/9] target/mips: Move translate.h to tcg/ sub directory, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 6/9] target/mips: Remove SmartMIPS / MDMX unuseful comments, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 7/9] target/mips: Remove microMIPS BPOSGE32 / BPOSGE64 unuseful cases, Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 8/9] target/mips: Constify host_to_mips_errno[], Philippe Mathieu-Daudé, 2021/06/17
- [PATCH 9/9] target/mips: Optimize regnames[] arrays, Philippe Mathieu-Daudé, 2021/06/17
- Re: [PATCH 0/9] target/mips: Various fixes & cleanups, Philippe Mathieu-Daudé, 2021/06/19