[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] tcg/plugins: enable by default for TCG builds
From: |
Willian Rampazzo |
Subject: |
Re: [RFC PATCH] tcg/plugins: enable by default for TCG builds |
Date: |
Fri, 25 Jun 2021 15:08:16 -0300 |
On Fri, Jun 25, 2021 at 8:27 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Aside from a minor bloat to file size the ability to have TCG plugins
> has no real impact on performance unless a plugin is actively loaded.
> Even then the libempty.so plugin shows only a minor degradation in
> performance caused by the extra book keeping the TCG has to do to keep
> track of instructions. As it's a useful feature lets just enable it by
> default and reduce our testing matrix a little.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> docs/devel/tcg-plugins.rst | 3 ++-
> configure | 2 +-
> .gitlab-ci.d/buildtest.yml | 23 -----------------------
> 3 files changed, 3 insertions(+), 25 deletions(-)
>
As far as code is concerned, it looks good to me.
Reviewed-by: WIllian Rampazzo <willianr@redhat.com>