Re: [PATCH v3 00/29] tcg: bswap improvements

[no-reply]

Patchew URL: 
20210626063631.2411938-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210626063631.2411938-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210626063631.2411938-1-richard.henderson@linaro.org
Subject: [PATCH v3 00/29] tcg: bswap improvements

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210625112741.12566-1-alex.bennee@linaro.org -> 
patchew/20210625112741.12566-1-alex.bennee@linaro.org
 * [new tag]         
patchew/20210626063631.2411938-1-richard.henderson@linaro.org -> 
patchew/20210626063631.2411938-1-richard.henderson@linaro.org
Switched to a new branch 'test'
e51efe0 tcg/riscv: Remove MO_BSWAP handling
4041b9f tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP
f136558 tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP
bcdc1b2 target/mips: Fix gen_mxu_s32ldd_s32lddr
6a4cd59 target/sh4: Improve swap.b translation
8477587 target/i386: Improve bswap translation
26ccc66 target/arm: Improve REVSH
da8e43e target/arm: Improve vector REV
fa6d277 target/arm: Improve REV32
88f5dcd tcg: Make use of bswap flags in tcg_gen_qemu_st_*
b0a635f tcg: Make use of bswap flags in tcg_gen_qemu_ld_*
3d607ce tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64
5357a0f tcg: Handle new bswap flags during optimize
bdb935c tcg/tci: Support bswap flags
af073d6 tcg/mips: Support bswap flags in tcg_out_bswap32
175d16f tcg/mips: Support bswap flags in tcg_out_bswap16
44fa033 tcg/s390: Support bswap flags
4399baa tcg/ppc: Use power10 byte-reverse instructions
54fe3bc tcg/ppc: Support bswap flags
44cc7ec tcg/ppc: Split out tcg_out_bswap64
012d7ff tcg/ppc: Split out tcg_out_bswap32
c10c9c8 tcg/ppc: Split out tcg_out_bswap16
1a8ab31 tcg/ppc: Split out tcg_out_sari{32,64}
70c6864 tcg/ppc: Split out tcg_out_ext{8,16,32}s
ec5717b tcg/arm: Support bswap flags
935c80a tcg/aarch64: Support bswap flags
d4e209d tcg/aarch64: Merge tcg_out_rev{16,32,64}
6697c42 tcg/i386: Support bswap flags
0b04ca4 tcg: Add flags argument to bswap opcodes

=== OUTPUT BEGIN ===
1/29 Checking commit 0b04ca4453f6 (tcg: Add flags argument to bswap opcodes)
2/29 Checking commit 6697c42f1198 (tcg/i386: Support bswap flags)
3/29 Checking commit d4e209dd23d4 (tcg/aarch64: Merge tcg_out_rev{16,32,64})
4/29 Checking commit 935c80acf207 (tcg/aarch64: Support bswap flags)
5/29 Checking commit ec5717bed008 (tcg/arm: Support bswap flags)
6/29 Checking commit 70c6864db927 (tcg/ppc: Split out tcg_out_ext{8,16,32}s)
7/29 Checking commit 1a8ab31694c7 (tcg/ppc: Split out tcg_out_sari{32,64})
8/29 Checking commit c10c9c82f0ce (tcg/ppc: Split out tcg_out_bswap16)
9/29 Checking commit 012d7ff11df3 (tcg/ppc: Split out tcg_out_bswap32)
10/29 Checking commit 44cc7ec9595f (tcg/ppc: Split out tcg_out_bswap64)
11/29 Checking commit 54fe3bceabce (tcg/ppc: Support bswap flags)
12/29 Checking commit 4399baae7d7f (tcg/ppc: Use power10 byte-reverse 
instructions)
13/29 Checking commit 44fa033dda86 (tcg/s390: Support bswap flags)
14/29 Checking commit 175d16f1fd15 (tcg/mips: Support bswap flags in 
tcg_out_bswap16)
15/29 Checking commit af073d696654 (tcg/mips: Support bswap flags in 
tcg_out_bswap32)
16/29 Checking commit bdb935c7d39b (tcg/tci: Support bswap flags)
17/29 Checking commit 5357a0ff6ff5 (tcg: Handle new bswap flags during optimize)
ERROR: spaces required around that ':' (ctx:VxE)
#41: FILE: tcg/optimize.c:1034:
+        CASE_OP_32_64(bswap16):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#94: FILE: tcg/optimize.c:1189:
+        CASE_OP_32_64(bswap16):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#95: FILE: tcg/optimize.c:1190:
+        CASE_OP_32_64(bswap32):
                               ^

total: 3 errors, 0 warnings, 82 lines checked

Patch 17/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/29 Checking commit 3d607ce1c6ac (tcg: Add flags argument to 
tcg_gen_bswap16_*, tcg_gen_bswap32_i64)
ERROR: code indent should never use tabs
#165: FILE: target/sh4/translate.c:680:
+^I    tcg_gen_bswap16_i32(low, low, TCG_BSWAP_IZ | TCG_BSWAP_OZ);$

total: 1 errors, 0 warnings, 296 lines checked

Patch 18/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/29 Checking commit b0a635f9e25a (tcg: Make use of bswap flags in 
tcg_gen_qemu_ld_*)
20/29 Checking commit 88f5dcdc4280 (tcg: Make use of bswap flags in 
tcg_gen_qemu_st_*)
21/29 Checking commit fa6d27781f5f (target/arm: Improve REV32)
22/29 Checking commit da8e43eac2ba (target/arm: Improve vector REV)
23/29 Checking commit 26ccc66ebc4b (target/arm: Improve REVSH)
24/29 Checking commit 8477587068bc (target/i386: Improve bswap translation)
25/29 Checking commit 6a4cd599d50a (target/sh4: Improve swap.b translation)
26/29 Checking commit bcdc1b2217ec (target/mips: Fix gen_mxu_s32ldd_s32lddr)
27/29 Checking commit f1365589a988 (tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP)
28/29 Checking commit 4041b9ff6ac3 (tcg/aarch64: Unset 
TCG_TARGET_HAS_MEMORY_BSWAP)
29/29 Checking commit e51efe0c6b8b (tcg/riscv: Remove MO_BSWAP handling)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210626063631.2411938-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210626063631.2411938-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com