[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction |
Date: |
Tue, 29 Jun 2021 10:22:44 +0100 |
On Mon, 28 Jun 2021 at 23:12, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/nios2/translate.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/target/nios2/translate.c b/target/nios2/translate.c
> index 6fd4330b31..9e71267b42 100644
> --- a/target/nios2/translate.c
> +++ b/target/nios2/translate.c
> @@ -753,7 +753,8 @@ static void handle_instruction(DisasContext *dc,
> CPUNios2State *env)
> op = get_opcode(code);
>
> if (unlikely(op >= ARRAY_SIZE(i_type_instructions))) {
> - goto illegal_op;
> + t_gen_helper_raise_exception(dc, EXCP_ILLEGAL);
> + return;
> }
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 0/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/28
- [PATCH v3 3/9] target/nios2: Use global cpu_R, Richard Henderson, 2021/06/28
- [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction, Richard Henderson, 2021/06/28
- Re: [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction,
Peter Maydell <=
- [PATCH v3 5/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/28
- [PATCH v3 2/9] target/nios2: Use global cpu_env, Richard Henderson, 2021/06/28
- [PATCH v3 1/9] target/nios2: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2021/06/28
- [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction, Richard Henderson, 2021/06/28
- [PATCH v3 9/9] target/nios2: Use pc_next for pc + 4, Richard Henderson, 2021/06/28
- [PATCH v3 8/9] target/nios2: Inline handle_instruction, Richard Henderson, 2021/06/28