[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_inst
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction |
Date: |
Tue, 29 Jun 2021 10:22:20 +0100 |
On Mon, 28 Jun 2021 at 23:12, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Direct assignments to env during translation do not work.
>
> As it happens, the only way we can get here is if env->pc
> is already set to dc->pc. We will trap on the first insn
> we execute anywhere on the page.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/nios2/translate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/nios2/translate.c b/target/nios2/translate.c
> index 66f4c25b06..6fd4330b31 100644
> --- a/target/nios2/translate.c
> +++ b/target/nios2/translate.c
> @@ -740,14 +740,15 @@ static void handle_instruction(DisasContext *dc,
> CPUNios2State *env)
> uint32_t code;
> uint8_t op;
> const Nios2Instruction *instr;
> +
> #if defined(CONFIG_USER_ONLY)
> /* FIXME: Is this needed ? */
> if (dc->pc >= 0x1000 && dc->pc < 0x2000) {
> - env->regs[R_PC] = dc->pc;
> t_gen_helper_raise_exception(dc, 0xaa);
> return;
> }
> #endif
> +
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 0/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/28
- [PATCH v3 3/9] target/nios2: Use global cpu_R, Richard Henderson, 2021/06/28
- [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction, Richard Henderson, 2021/06/28
- [PATCH v3 5/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/28
- [PATCH v3 2/9] target/nios2: Use global cpu_env, Richard Henderson, 2021/06/28
- [PATCH v3 1/9] target/nios2: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2021/06/28
- [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction, Richard Henderson, 2021/06/28
- Re: [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction,
Peter Maydell <=
- [PATCH v3 9/9] target/nios2: Use pc_next for pc + 4, Richard Henderson, 2021/06/28
- [PATCH v3 8/9] target/nios2: Inline handle_instruction, Richard Henderson, 2021/06/28
- [PATCH v3 4/9] target/nios2: Add DisasContextBase to DisasContext, Richard Henderson, 2021/06/28
- Re: [PATCH v3 0/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/29