[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction |
Date: |
Tue, 29 Jun 2021 14:55:37 +0100 |
On Tue, 29 Jun 2021 at 14:53, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 6/29/21 2:27 AM, Peter Maydell wrote:
> > On Mon, 28 Jun 2021 at 23:13, Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >>
> >> Move handle_instruction into nios2_tr_translate_insn
> >> as the only caller.
> >>
> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >> ---
> >> target/nios2/translate.c | 66 +++++++++++++++++++---------------------
> >> 1 file changed, 31 insertions(+), 35 deletions(-)
> >
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > Side note: I think we could replace all the handling of dc->zero
> > by having load_gpr() return a tcg_constant_i32(0) for R_ZERO,
> > which then never needs freeing. (We never try to write back
> > to what we get from load_gpr().)
>
> Quite right. There are several targets that could benefit from that
> simplification.
I'm still hoping one day you'll get around to making tcg_temp_free_*()
calls entirely unnecessary :-)
-- PMM
- Re: [PATCH v3 5/9] target/nios2: Convert to TranslatorOps, (continued)
- [PATCH v3 2/9] target/nios2: Use global cpu_env, Richard Henderson, 2021/06/28
- [PATCH v3 1/9] target/nios2: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2021/06/28
- [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction, Richard Henderson, 2021/06/28
- [PATCH v3 9/9] target/nios2: Use pc_next for pc + 4, Richard Henderson, 2021/06/28
- [PATCH v3 8/9] target/nios2: Inline handle_instruction, Richard Henderson, 2021/06/28
- [PATCH v3 4/9] target/nios2: Add DisasContextBase to DisasContext, Richard Henderson, 2021/06/28
- Re: [PATCH v3 0/9] target/nios2: Convert to TranslatorOps, Richard Henderson, 2021/06/29