[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64
From: |
Richard Henderson |
Subject: |
[PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64 |
Date: |
Thu, 8 Jul 2021 09:40:28 -0700 |
We have not needed to end a TB for I/O since ba3e7926691
("icount: clean up cpu_can_io at the entry to the block"),
and gdbstub singlestep is handled by the generic function.
Drop the unused 'n' argument to use_goto_tb.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate-a64.c | 25 +++++--------------------
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index e81cc20d04..856a689b90 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -386,35 +386,20 @@ static void gen_step_complete_exception(DisasContext *s)
s->base.is_jmp = DISAS_NORETURN;
}
-static inline bool use_goto_tb(DisasContext *s, int n, uint64_t dest)
+static inline bool use_goto_tb(DisasContext *s, uint64_t dest)
{
- /* No direct tb linking with singlestep (either QEMU's or the ARM
- * debug architecture kind) or deterministic io
- */
- if (s->base.singlestep_enabled || s->ss_active ||
- (tb_cflags(s->base.tb) & CF_LAST_IO)) {
+ if (s->ss_active) {
return false;
}
-
-#ifndef CONFIG_USER_ONLY
- /* Only link tbs from inside the same guest page */
- if ((s->base.tb->pc & TARGET_PAGE_MASK) != (dest & TARGET_PAGE_MASK)) {
- return false;
- }
-#endif
-
- return true;
+ return translator_use_goto_tb(&s->base, dest);
}
static inline void gen_goto_tb(DisasContext *s, int n, uint64_t dest)
{
- const TranslationBlock *tb;
-
- tb = s->base.tb;
- if (use_goto_tb(s, n, dest)) {
+ if (use_goto_tb(s, dest)) {
tcg_gen_goto_tb(n);
gen_a64_set_pc_im(dest);
- tcg_gen_exit_tb(tb, n);
+ tcg_gen_exit_tb(s->base.tb, n);
s->base.is_jmp = DISAS_NORETURN;
} else {
gen_a64_set_pc_im(dest);
--
2.25.1
- [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 01/28] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64,
Richard Henderson <=
- [PATCH v3 02/28] target/alpha: Remove use_exit_tb, Richard Henderson, 2021/07/08
- [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB, Richard Henderson, 2021/07/08
- [PATCH v3 13/28] target/m68k: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32, Richard Henderson, 2021/07/08
- [PATCH v3 03/28] target/alpha: Remove in_superpage, Richard Henderson, 2021/07/08
- [PATCH v3 12/28] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 10/28] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 09/28] target/avr: Mark some helpers noreturn, Richard Henderson, 2021/07/08
- [PATCH v3 08/28] target/avr: Use translator_use_goto_tb, Richard Henderson, 2021/07/08