[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB
From: |
Richard Henderson |
Subject: |
[PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB |
Date: |
Thu, 8 Jul 2021 09:40:27 -0700 |
Using gen_goto_tb directly misses the single-step check.
Let the branch or debug exception be emitted by arm_tr_tb_stop.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 28e478927d..293917be4f 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -8905,7 +8905,7 @@ static bool trans_ISB(DisasContext *s, arg_ISB *a)
* self-modifying code correctly and also to take
* any pending interrupts immediately.
*/
- gen_goto_tb(s, 0, s->base.pc_next);
+ s->base.is_jmp = DISAS_TOO_MANY;
return true;
}
@@ -8919,7 +8919,7 @@ static bool trans_SB(DisasContext *s, arg_SB *a)
* for TCG; MB and end the TB instead.
*/
tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
- gen_goto_tb(s, 0, s->base.pc_next);
+ s->base.is_jmp = DISAS_TOO_MANY;
return true;
}
--
2.25.1
- [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 01/28] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64, Richard Henderson, 2021/07/08
- [PATCH v3 02/28] target/alpha: Remove use_exit_tb, Richard Henderson, 2021/07/08
- [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB,
Richard Henderson <=
- [PATCH v3 13/28] target/m68k: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32, Richard Henderson, 2021/07/08
- [PATCH v3 03/28] target/alpha: Remove in_superpage, Richard Henderson, 2021/07/08
- [PATCH v3 12/28] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 10/28] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 09/28] target/avr: Mark some helpers noreturn, Richard Henderson, 2021/07/08
- [PATCH v3 08/28] target/avr: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 15/28] target/mips: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 25/28] target/sparc: Use translator_use_goto_tb, Richard Henderson, 2021/07/08
- [PATCH v3 11/28] target/hppa: Use translator_use_goto_tb, Richard Henderson, 2021/07/08