[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_s
From: |
Sergio Lopez |
Subject: |
Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init() |
Date: |
Tue, 20 Jul 2021 15:36:47 +0200 |
On Tue, Jul 20, 2021 at 02:54:03PM +0200, Markus Armbruster wrote:
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
>
> Cc: Sergio Lopez <slp@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/i386/microvm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -458,15 +458,10 @@ static void microvm_machine_state_init(MachineState
> *machine)
> {
> MicrovmMachineState *mms = MICROVM_MACHINE(machine);
> X86MachineState *x86ms = X86_MACHINE(machine);
> - Error *local_err = NULL;
>
> microvm_memory_init(mms);
>
> x86_cpus_init(x86ms, CPU_VERSION_LATEST);
> - if (local_err) {
> - error_report_err(local_err);
> - exit(1);
> - }
>
> microvm_devices_init(mms);
> }
> --
> 2.31.1
>
Reviewed-by: Sergio Lopez <slp@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 09/16] migration: Unify failure check for migrate_add_blocker(), (continued)
- [PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently, Markus Armbruster, 2021/07/20
- [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly, Markus Armbruster, 2021/07/20
- [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 05/16] vhost-scsi: Plug memory leak on migrate_add_blocker() failure, Markus Armbruster, 2021/07/20
- [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init(), Markus Armbruster, 2021/07/20
- [PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling, Markus Armbruster, 2021/07/20
- [PATCH 15/16] vl: Clean up -smp error handling, Markus Armbruster, 2021/07/20
- [PATCH 14/16] Remove superfluous ERRP_GUARD(), Markus Armbruster, 2021/07/20
- [PATCH 16/16] vl: Don't continue after -smp help., Markus Armbruster, 2021/07/20