qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename
Date: Tue, 21 Sep 2021 07:17:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 9/17/21 16:31, Markus Armbruster wrote:
> Commit b359f4b203 "tests: Rename UserDefNativeListUnion to
> UserDefListUnion" renamed test_clone_native_list() to
> test_clone_list_union().  The function has nothing to do with unions.
> Rename it to test_clone_list().
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/unit/test-clone-visitor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Maybe nitpicking, while this patch is related to the series,
although I understand you noticed the mistake while working
on this series, I'd move this cleanup as 1/23.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]