[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename |
Date: |
Sat, 25 Sep 2021 07:01:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 9/17/21 16:31, Markus Armbruster wrote:
>> Commit b359f4b203 "tests: Rename UserDefNativeListUnion to
>> UserDefListUnion" renamed test_clone_native_list() to
>> test_clone_list_union(). The function has nothing to do with unions.
>> Rename it to test_clone_list().
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>> tests/unit/test-clone-visitor.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Maybe nitpicking, while this patch is related to the series,
> although I understand you noticed the mistake while working
> on this series, I'd move this cleanup as 1/23.
Not worth a respin. Next time!
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
- [PATCH v2 06/23] qapi: Convert simple union MemoryDeviceInfo to flat one, (continued)
- [PATCH v2 06/23] qapi: Convert simple union MemoryDeviceInfo to flat one, Markus Armbruster, 2021/09/17
- [PATCH v2 16/23] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop, Markus Armbruster, 2021/09/17
- [PATCH v2 15/23] tests/qapi-schema: Wean off UserDefListUnion, Markus Armbruster, 2021/09/17
- [PATCH v2 05/23] qapi: Convert simple union TpmTypeOptions to flat one, Markus Armbruster, 2021/09/17
- [PATCH v2 03/23] qapi: Convert simple union KeyValue to flat one, Markus Armbruster, 2021/09/17
- [PATCH v2 11/23] tests/qapi-schema: Prepare for simple union UserDefListUnion removal, Markus Armbruster, 2021/09/17
- [PATCH v2 07/23] qapi: Convert simple union ChardevBackend to flat one, Markus Armbruster, 2021/09/17
- [PATCH v2 19/23] tests/qapi-schema: Drop simple union __org.qemu_x-Union1, Markus Armbruster, 2021/09/17
- [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename, Markus Armbruster, 2021/09/17
- [PATCH v2 13/23] test-qobject-output-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/17
- [PATCH v2 20/23] tests/qapi-schema: Purge simple unions from tests, Markus Armbruster, 2021/09/17
- [PATCH v2 21/23] qapi: Drop simple unions, Markus Armbruster, 2021/09/17
- [PATCH v2 08/23] qapi: Convert simple union SocketAddressLegacy to flat one, Markus Armbruster, 2021/09/17
- [PATCH v2 14/23] test-clone-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/17
- [PATCH v2 18/23] test-clone-visitor: Wean off __org.qemu_x-Union1, Markus Armbruster, 2021/09/17
- [PATCH v2 22/23] tests/qapi-schema: Rename flat-union-* test cases to union-*, Markus Armbruster, 2021/09/17
- [PATCH v2 02/23] qapi: Stop enforcing "type name should not end in 'Kind', Markus Armbruster, 2021/09/17
- [PATCH v2 10/23] qapi: Convert simple union TransactionAction to flat one, Markus Armbruster, 2021/09/17