Re: [PATCH v2 08/32] target/mips: Convert MSA LDI opcode to decodetree

[Richard Henderson]

On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
> Convert the LDI opcode (Immediate Load) to decodetree. Since it
> overlaps with the generic MSA handler, use a decodetree overlap
> group.
>
> Since the 'data format' field is a constant value, use
> tcg_constant_i32() instead of a TCG temporary.
>
> Reviewed-by: Jiaxun Yang<jiaxun.yang@flygoat.com>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> v2:
> - add &msa_ldi format
> - !check_msa_enabled -> return true
> - TCG timm is constant
> ---
>   target/mips/tcg/msa.decode      |  8 +++++++-
>   target/mips/tcg/msa_translate.c | 22 ++++++++++++++--------
>   2 files changed, 21 insertions(+), 9 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~