[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 20/23] hw/timer/sh_timer: Rename sh_timer_state to SHTimer
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 20/23] hw/timer/sh_timer: Rename sh_timer_state to SHTimerState |
Date: |
Fri, 29 Oct 2021 07:47:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/28/21 21:27, BALATON Zoltan wrote:
> According to coding style types should be camel case, also remove
> unneded casts from void *.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> The tmu123_state is left for now, that's the real exported object with
> SHTimerState being an internal object for a single timer. I'll come
> back to this when QOM-ifying so only handled SHTimerState in this patch.
>
> hw/timer/sh_timer.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initialisers, (continued)
- [PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initialisers, BALATON Zoltan, 2021/10/28
- [PATCH v4 09/23] hw/intc/sh_intc: Turn some defines into an enum, BALATON Zoltan, 2021/10/28
- [PATCH v4 06/23] hw/char/sh_serial: QOM-ify, BALATON Zoltan, 2021/10/28
- [PATCH v4 13/23] hw/intc/sh_intc: Remove excessive parenthesis, BALATON Zoltan, 2021/10/28
- [PATCH v4 11/23] hw/intc/sh_intc: Drop another useless macro, BALATON Zoltan, 2021/10/28
- [PATCH v4 23/23] hw/timer/sh_timer: Fix timer memory region size, BALATON Zoltan, 2021/10/28
- [PATCH v4 20/23] hw/timer/sh_timer: Rename sh_timer_state to SHTimerState, BALATON Zoltan, 2021/10/28
- Re: [PATCH v4 20/23] hw/timer/sh_timer: Rename sh_timer_state to SHTimerState,
Philippe Mathieu-Daudé <=
- [PATCH v4 16/23] hw/intc/sh_intc: Replace abort() with g_assert_not_reached(), BALATON Zoltan, 2021/10/28
- [PATCH v4 21/23] hw/timer/sh_timer: Fix format strings and remove casts, BALATON Zoltan, 2021/10/28
- [PATCH v4 22/23] hw/timer/sh_timer: Do not wrap lines that are not too long, BALATON Zoltan, 2021/10/28
- [PATCH v4 17/23] hw/intc/sh_intc: Avoid using continue in loops, BALATON Zoltan, 2021/10/28
- [PATCH v4 18/23] hw/intc/sh_intc: Simplify allocating sources array, BALATON Zoltan, 2021/10/28