[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/11] Fixed qemu crash when guest power off in COLO mode
From: |
Juan Quintela |
Subject: |
[PULL 05/11] Fixed qemu crash when guest power off in COLO mode |
Date: |
Wed, 3 Nov 2021 09:45:59 +0100 |
From: "Rao, Lei" <lei.rao@intel.com>
This patch fixes the following:
qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'running'
Aborted (core dumped)
The gdb bt as following:
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
1 0x00007faa3d613859 in __GI_abort () at abort.c:79
2 0x000055c5a21268fd in runstate_set (new_state=RUN_STATE_RUNNING) at vl.c:723
3 0x000055c5a1f8cae4 in vm_prepare_start () at
/home/workspace/colo-qemu/cpus.c:2206
4 0x000055c5a1f8cb1b in vm_start () at /home/workspace/colo-qemu/cpus.c:2213
5 0x000055c5a2332bba in migration_iteration_finish (s=0x55c5a4658810) at
migration/migration.c:3376
6 0x000055c5a2332f3b in migration_thread (opaque=0x55c5a4658810) at
migration/migration.c:3527
7 0x000055c5a251d68a in qemu_thread_start (args=0x55c5a5491a70) at
util/qemu-thread-posix.c:519
8 0x00007faa3d7e9609 in start_thread (arg=<optimized out>) at
pthread_create.c:477
9 0x00007faa3d710293 in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95
Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index edc0dac80a..3fb856f6e1 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3626,7 +3626,9 @@ static void migration_iteration_finish(MigrationState *s)
case MIGRATION_STATUS_CANCELLED:
case MIGRATION_STATUS_CANCELLING:
if (s->vm_was_running) {
- vm_start();
+ if (!runstate_check(RUN_STATE_SHUTDOWN)) {
+ vm_start();
+ }
} else {
if (runstate_check(RUN_STATE_FINISH_MIGRATE)) {
runstate_set(RUN_STATE_POSTMIGRATE);
--
2.33.1
- [PULL 00/11] Migration 20211102 patches, Juan Quintela, 2021/11/03
- [PULL 08/11] Removed the qemu_fclose() in colo_process_incoming_thread, Juan Quintela, 2021/11/03
- [PULL 09/11] Changed the last-mode to none of first start COLO, Juan Quintela, 2021/11/03
- [PULL 01/11] migration: provide an error message to migration_cancel(), Juan Quintela, 2021/11/03
- [PULL 02/11] migration: initialise compression_counters for a new migration, Juan Quintela, 2021/11/03
- [PULL 05/11] Fixed qemu crash when guest power off in COLO mode,
Juan Quintela <=
- [PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off, Juan Quintela, 2021/11/03
- [PULL 11/11] Optimized the function of fill_connection_key., Juan Quintela, 2021/11/03
- [PULL 06/11] Fixed SVM hang when do failover before PVM crash, Juan Quintela, 2021/11/03
- [PULL 07/11] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff, Juan Quintela, 2021/11/03
- [PULL 04/11] Some minor optimizations for COLO, Juan Quintela, 2021/11/03
- [PULL 03/11] migration: Zero migration compression counters, Juan Quintela, 2021/11/03
- Re: [PULL 00/11] Migration 20211102 patches, Richard Henderson, 2021/11/04