[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off
From: |
Juan Quintela |
Subject: |
[PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off |
Date: |
Wed, 3 Nov 2021 09:46:04 +0100 |
From: Lukas Straub <lukasstraub2@web.de>
One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/ram.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index f5d39db4e4..847af461f2 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
#include "multifd.h"
#include "sysemu/runstate.h"
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
#if defined(__linux__)
#include "qemu/userfaultfd.h"
#endif /* defined(__linux__) */
@@ -3542,6 +3544,10 @@ int colo_init_ram_cache(void)
}
return -errno;
}
+ if (!machine_dump_guest_core(current_machine)) {
+ qemu_madvise(block->colo_cache, block->used_length,
+ QEMU_MADV_DONTDUMP);
+ }
}
}
--
2.33.1
- [PULL 00/11] Migration 20211102 patches, Juan Quintela, 2021/11/03
- [PULL 08/11] Removed the qemu_fclose() in colo_process_incoming_thread, Juan Quintela, 2021/11/03
- [PULL 09/11] Changed the last-mode to none of first start COLO, Juan Quintela, 2021/11/03
- [PULL 01/11] migration: provide an error message to migration_cancel(), Juan Quintela, 2021/11/03
- [PULL 02/11] migration: initialise compression_counters for a new migration, Juan Quintela, 2021/11/03
- [PULL 05/11] Fixed qemu crash when guest power off in COLO mode, Juan Quintela, 2021/11/03
- [PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off,
Juan Quintela <=
- [PULL 11/11] Optimized the function of fill_connection_key., Juan Quintela, 2021/11/03
- [PULL 06/11] Fixed SVM hang when do failover before PVM crash, Juan Quintela, 2021/11/03
- [PULL 07/11] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff, Juan Quintela, 2021/11/03
- [PULL 04/11] Some minor optimizations for COLO, Juan Quintela, 2021/11/03
- [PULL 03/11] migration: Zero migration compression counters, Juan Quintela, 2021/11/03
- Re: [PULL 00/11] Migration 20211102 patches, Richard Henderson, 2021/11/04