Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test

[Alex Bennée]

Taylor Simpson <tsimpson@quicinc.com> writes:

>> -----Original Message-----
>> From: Alex Bennée <alex.bennee@linaro.org>
>> Sent: Tuesday, November 2, 2021 11:42 AM
>> To: Taylor Simpson <tsimpson@quicinc.com>
>> Cc: Richard Henderson <richard.henderson@linaro.org>; Philippe Mathieu-
>> Daudé <f4bug@amsat.org>; qemu-devel@nongnu.org;
>> peter.maydell@linaro.org
>> Subject: Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test
>> 
>> Taylor Simpson <tsimpson@quicinc.com> writes:
>> 
>> >> -----Original Message-----
>> >> From: Richard Henderson <richard.henderson@linaro.org>
>> >> Sent: Monday, November 1, 2021 10:03 AM
>> >> To: Philippe Mathieu-Daudé <f4bug@amsat.org>; Taylor Simpson
>> >> <tsimpson@quicinc.com>; qemu-devel@nongnu.org; Alex Bennée
>> >> <alex.bennee@linaro.org>
>> >> Cc: peter.maydell@linaro.org
>> >> Subject: Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc
>> >> test
>> >>
>> >> On 11/1/21 10:17 AM, Philippe Mathieu-Daudé wrote:
>> >> > On 11/1/21 15:09, Taylor Simpson wrote:
>> >> >> Plan-A should be to update the container with the new toolchain.
>> >> >
>> >> > IIUC Richard is going with Plan-A: wait Alex queue get merged, then
>> >> > retry merging this pull request.
>> >>
>> >> Correct.
>> >
>> > Agreed.  Just let me know if Alex isn't going to get the new toolchain
>> > merged in time, and I can go to plan B.
>> 
>> The PR has been a pain to get working but it should be in soon. Just need to
>> work out why the signals test has broken between master and my
>> PR:
>> 
>>  https://gitlab.com/qemu-project/qemu/-/jobs/1739288510#L1318
>> 
>> vs
>> 
>>  https://gitlab.com/stsquad/qemu/-/jobs/1740048034#L1316
>> 
>> Could it be a toolchain thing?
>
> Not likely a toolchain problem.  If I can access both of the signals
> binaries, I can confirm.

Testing against two signals binaries I see a 4-7% failure rate against the
new binary versus the original pre-toolchain change one. That's not to
say the binary is broken - it could be a subtle change that exacerbated
our existing poor signals support. 

  https://transfer.sh/xA2ejk/signals.old (pre-toolchain change)
  https://transfer.sh/vSsn5s/signals

something in the CI ensures it fails much more reliably as U can't get
it to pass on a retry.

>
> Richard was doing some changes in qemu related to signals.  Are his
> changes available in both repos?

I've tested against master and rth/tgt-next (742f07628c0)

>
>
> Taylor


-- 
Alex Bennée