On Wed, Nov 03, 2021 at 10:48:40AM -0400, John Snow wrote:
> Clang doesn't recognize that the variable is being "used" and will emit
> a warning:
>
> ../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable]
> g_autoptr(QemuClipboardInfo) old = NULL;
> ^
> 1 error generated.
>
> OK, fine. Just do things the old way.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> ui/clipboard.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/clipboard.c b/ui/clipboard.c
> index d7b008d62a..d53576b0f6 100644
> --- a/ui/clipboard.c
> +++ b/ui/clipboard.c
> @@ -44,13 +44,14 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
>
> void qemu_clipboard_update(QemuClipboardInfo *info)
> {
> - g_autoptr(QemuClipboardInfo) old = NULL;
> + QemuClipboardInfo *old = NULL;
> assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
>
> notifier_list_notify(&clipboard_notifiers, info);
>
> old = cbinfo[info->selection];
> cbinfo[info->selection] = qemu_clipboard_info_ref(info);
> + g_free(old);
> }
Surely the right answer here is to get rid of the variable
entirely as it isn't adding value
g_free(cbinfo[info->selection]);
Alrighty, I'll clean it up.
Respin pending comments on 1/6 and 6/6.
--js