[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 15/23] target/mips: Extract break code into env->error_cod

From: Richard Henderson
Subject: Re: [PATCH v3 15/23] target/mips: Extract break code into env->error_code
Date: Wed, 3 Nov 2021 11:38:01 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/3/21 11:11 AM, Philippe Mathieu-Daudé wrote:
+            /*
+             * As described in the original Linux kernel code, the below
+             * checks on 'code' are to work around an old assembly bug.
+             */
+            code = env->error_code;
+            if (code >= (1 << 10)) {
+                code >>= 10;

Shouldn't we also move this to the translation (not in R6_BREAK16)?

No, because it's a kernel thing, not a cpu thing:



PS: Just above, it looks like the kernel would need to grow support for R6_BREAK. At present it only handles mips16e and micromips.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]