Re: [PATCH v3 15/23] target/mips: Extract break code into env->error_code

[Richard Henderson]

On 11/3/21 11:11 AM, Philippe Mathieu-Daudé wrote:
> > +            /*
> > +             * As described in the original Linux kernel code, the below
> > +             * checks on 'code' are to work around an old assembly bug.
> > +             */
> > +            code = env->error_code;
> > +            if (code >= (1 << 10)) {
> > +                code >>= 10;
>
> Shouldn't we also move this to the translation (not in R6_BREAK16)?

No, because it's a kernel thing, not a cpu thing:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/kernel/traps.c#n1056


r~


PS: Just above, it looks like the kernel would need to grow support for R6_BREAK.  At 
present it only handles mips16e and micromips.