Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies

[Paolo Bonzini]

On 11/8/21 10:53, Philippe Mathieu-Daudé wrote:
> >   config VHOST_USER_SCSI
> >       bool
> > +    default y
> >       # Only PCI devices are provided for now
> > -    default y if VIRTIO_PCI
> > -    depends on VIRTIO && VHOST_USER && LINUX
> > +    depends on VIRTIO_PCI && VHOST_USER && LINUX
> But there is no PCI call there:

Yeah, you're right.  You can still access the device on virtio-mmio via 
-device vhost-user-scsi.

> $ git grep pci hw/scsi/vhost*scsi*
> $
>
> Don't we want to add VHOST_USER_SCSI_PCI in
> hw/virtio/Kconfig instead?

In practice you already have hw/virtio/vhost-user-scsi.pci conditional 
on "CONFIG_VHOST_USER_SCSI && CONFIG_VIRTIO_PCI", and further 
configuration is not too useful.

I think the best option is to either make it "default y if VIRTIO_PCI || 
VIRTIO_MMIO", or bite the bullet and add the ccw proxy devices.

Paolo