[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies

From: Paolo Bonzini
Subject: Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies
Date: Mon, 8 Nov 2021 11:53:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 11/8/21 10:53, Philippe Mathieu-Daudé wrote:
+    default y
      # Only PCI devices are provided for now
-    default y if VIRTIO_PCI
-    depends on VIRTIO && VHOST_USER && LINUX
+    depends on VIRTIO_PCI && VHOST_USER && LINUX
But there is no PCI call there:

Yeah, you're right. You can still access the device on virtio-mmio via -device vhost-user-scsi.

$ git grep pci hw/scsi/vhost*scsi*

Don't we want to add VHOST_USER_SCSI_PCI in
hw/virtio/Kconfig instead?

In practice you already have hw/virtio/vhost-user-scsi.pci conditional on "CONFIG_VHOST_USER_SCSI && CONFIG_VIRTIO_PCI", and further configuration is not too useful.

I think the best option is to either make it "default y if VIRTIO_PCI || VIRTIO_MMIO", or bite the bullet and add the ccw proxy devices.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]