[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/15] hw/nvme: Implement the Function Level Reset
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v2 08/15] hw/nvme: Implement the Function Level Reset |
|
Date: |
Tue, 16 Nov 2021 13:28:19 -0800 |
On Tue, Nov 16, 2021 at 04:34:39PM +0100, Łukasz Gieryk wrote:
> if (!pci_is_vf(&n->parent_obj) && n->params.sriov_max_vfs) {
> - pcie_sriov_pf_disable_vfs(&n->parent_obj);
> + if (rst != NVME_RESET_CONTROLLER) {
> + pcie_sriov_pf_disable_vfs(&n->parent_obj);
Shouldn't this be 'if (rst == NVME_RESET_FUNCTION)'?
- [PATCH v2 00/15] hw/nvme: SR-IOV with Virtualization Enhancements, Łukasz Gieryk, 2021/11/16
- [PATCH v2 01/15] pcie: Add support for Single Root I/O Virtualization (SR/IOV), Łukasz Gieryk, 2021/11/16
- [PATCH v2 02/15] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt, Łukasz Gieryk, 2021/11/16
- [PATCH v2 04/15] pcie: Add 1.2 version token for the Power Management Capability, Łukasz Gieryk, 2021/11/16
- [PATCH v2 05/15] hw/nvme: Add support for SR-IOV, Łukasz Gieryk, 2021/11/16
- [PATCH v2 06/15] hw/nvme: Add support for Primary Controller Capabilities, Łukasz Gieryk, 2021/11/16
- [PATCH v2 07/15] hw/nvme: Add support for Secondary Controller List, Łukasz Gieryk, 2021/11/16
- [PATCH v2 08/15] hw/nvme: Implement the Function Level Reset, Łukasz Gieryk, 2021/11/16
- Re: [PATCH v2 08/15] hw/nvme: Implement the Function Level Reset,
Keith Busch <=
- [PATCH v2 09/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime, Łukasz Gieryk, 2021/11/16
- [PATCH v2 10/15] hw/nvme: Remove reg_size variable and update BAR0 size calculation, Łukasz Gieryk, 2021/11/16
- [PATCH v2 03/15] pcie: Add helpers to the SR/IOV API, Łukasz Gieryk, 2021/11/16
- [PATCH v2 11/15] hw/nvme: Calculate BAR attributes in a function, Łukasz Gieryk, 2021/11/16
- [PATCH v2 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers, Łukasz Gieryk, 2021/11/16
- [PATCH v2 14/15] docs: Add documentation for SR-IOV and Virtualization Enhancements, Łukasz Gieryk, 2021/11/16