qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/3] kvm: Support for querying fd-based stats


From: Paolo Bonzini
Subject: Re: [PATCH v3 3/3] kvm: Support for querying fd-based stats
Date: Tue, 1 Feb 2022 11:51:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 1/31/22 20:43, Mark Kanda wrote:

+    for (i = 0; i < header->num_desc; ++i) {
+        struct kvm_stats_desc *pdesc = (void *)stats_desc + i * size_desc;
+        size_data = pdesc->size * sizeof(uint64_t);
+
+        uint64_t *stats_data = g_malloc(size_data);
+
+        ret = pread(stats_fd, stats_data, size_data,
+                    header->data_offset + pdesc->offset);

How hard would it be to cache the descriptors? Ideally, a query-stats command would do only one pread.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]