Re: [PATCH v3 1/3] qmp: Support for querying stats

[Paolo Bonzini]

On 1/31/22 20:43, Mark Kanda wrote:
> { "execute": "query-stats", "arguments" : { "target": "vm" } }
> { "return": {
>      "list": [
>        { "provider": "kvm",
>          "stats": [
>            { "name": "max_mmu_page_hash_collisions", "value": 0 },
>            { "name": "max_mmu_rmap_size", "value": 0 },
>            { "name": "nx_lpage_splits", "value": 131 },
>           ...
>          ] }
>        { "provider": "provider XYZ",
>        ...
>      ],
>      "target": "vm"
>    }
> }

Perhaps it's better to have a better name than "list" for clarity, like 
you already did with 'stats':

{ 'struct': 'VCPUResultsEntry',
  'data': { 'path': 'str',
            'providers': [ 'StatsResultsEntry' ] } }

{ 'struct': 'VCPUStatsResults',
  'data': { 'objects': [ 'VCPUResultsEntry' ] } }


{ 'struct': 'VMStatsResults',
  'data': { 'providers' : [ 'StatsResultsEntry' ] } }

Also, here:

> +{ 'alternate': 'StatsValue',
> +  'data': { 'scalar': 'uint64',
> +            'list': 'StatsValueArray' } }

is it possible to just do

{ 'alternate': 'StatsValue',
  'data': { 'scalar': 'uint64',
            'list': ['uint64'] } }



Thanks,

Paolo