Re: [PATCH 2/2] tests: Update CentOS 8 container to CentOS Stream 8

[Andrea Bolognani]

On Tue, Feb 01, 2022 at 11:19:11AM +0100, Thomas Huth wrote:
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -1,10 +1,10 @@
>  # THIS FILE WAS AUTO-GENERATED
>  #
> -#  $ lcitool dockerfile centos-8 qemu
> +#  $ lcitool dockerfile centos-stream-8 qemu
>  #
>  # https://gitlab.com/libvirt/libvirt-ci
>
> -FROM docker.io/library/centos:8
> +FROM quay.io/centos/centos:stream8
[...]
> +++ b/tests/lcitool/refresh
> @@ -77,7 +77,7 @@ ubuntu2004_tsanhack = [
>  ]
>
>  try:
> -   generate_dockerfile("centos8", "centos-8")
> +   generate_dockerfile("centos8", "centos-stream-8")

I'm not convinced this is a good idea.

CentOS 8 and CentOS Stream 8 are two pretty distinct operating
systems in terms of update cadence and stability expectations, so I
think that using the label "centos8" for containers and CI jobs that
are actually consuming CentOS Stream 8 is going to be a source of
confusion.

I recommend proceeding with a thorough rename, after which the string
"centos8" no longer shows up anywhere, instead.

-- 
Andrea Bolognani / Red Hat / Virtualization