|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v3 1/3] qmp: Support for querying stats |
Date: | Thu, 3 Feb 2022 19:38:08 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
On 2/1/22 13:08, Daniel P. Berrangé wrote:
I still feel like this is rather verbose, and should be simplified down to. { "return": { "vm": { "kvm": [ ... ] "provider-XYZ": [ ... ], ... } }
My main qualm with this is that not just QEMU, but every layer above then needs to either treat stats as a "dynamic" type unless they want to only handle providers that they know.
The main reason why I asked Mark to do all this work, was so that new stats and stats providers could be added transparently, and only new *targets* would need work all over the stack (but those are fewer, for example blockdev/netdev/iothread).
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |