Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

[Liviu Ionescu]

> On 9 Feb 2022, at 11:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> 
> Is the existing ./configure --with-pkgversion= option not enough?

My understanding of --with-pkgversion=, based on the fact that in QEMU this 
string is appended to the version, was that it is a suffix that describes a 
specific version.

Most GNU tools, including GCC, binutils, etc, use a similar option, but the 
string is prepended to the greeting message.

In my use case, --with-branding-prefix does the same, QEMU presents itself with:

.../xpack-qemu-arm-6.2.0-1/bin/qemu-system-arm --version
xPack QEMU emulator version 6.2.0 (v6.2.0-1-xpack-arm)
Copyright (c) 2003-2021 Fabrice Bellard and the QEMU Project developers

All other binary xPacks (https://github.com/xpack-dev-tools/) do the same.

In my opinion, a prefix is preferred, and is consistent with the GNU behaviour.

Anyway, having both does not break any backward compatibility and does not add 
any significant overhead/complexity.


Liviu