Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

[Peter Maydell]

On Mon, 14 Feb 2022 at 11:54, Liviu Ionescu <ilg@livius.net> wrote:
> Would you agree on a multi step approach, first a minimal patch that would 
> solve my use case, then, if there will be others needing it, a more elaborate 
> solution?
>
> For example I don't mind having to pass a preprocessor definition to my 
> build; so how about something like:
>
>
> ```c
> static void version(void)
> {
> +#if defined(QEMU_BRANDING_PREFIX)
> +    printf("%s ", QEMU_BRANDING_PREFIX);
> +#endif
>     printf("QEMU emulator version " QEMU_FULL_VERSION "\n"
>            QEMU_COPYRIGHT "\n");
> }
> ```

Either we want the feature upstream, or we don't. If we do, then
we want the whole thing including the configure option. If we don't,
then we don't want any of it, and that includes not having this kind
of ifdef.

So far you haven't really described a use case that --with-pkgversion
wouldn't satisfy. You say:

> Seeing the branded greeting in a console log is a visual confirmation
> that the test script used the desired version, and not another version
> picked up by mistake when using an incorrect PATH.

but the "v6.2.0-1-xpack-arm" pkgversion suffix works for this
purpose too.

thanks
-- PMM