Re: [PATCH] Deprecate C virtiofsd

[Dr. David Alan Gilbert]

* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Wed, Feb 09, 2022 at 04:50:40PM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > There's a nice new Rust implementation out there; recommend people
> > do new work on that.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> >  docs/about/deprecated.rst | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> > index 47a594a3b6..3a0e15f8f5 100644
> > --- a/docs/about/deprecated.rst
> > +++ b/docs/about/deprecated.rst
> > @@ -454,3 +454,17 @@ nanoMIPS ISA
> >  
> >  The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
> >  As it is hard to generate binaries for it, declare it deprecated.
> > +
> > +Tools
> > +-----
> > +
> > +virtiofsd
> > +'''''''''
> > +
> > +There is a new Rust implementation of ``virtiofs`` at
> > +``https://gitlab.com/virtio-fs/virtiofsd``;
> > +since this is now marked stable, new development should be done on that
> > +rather than the existing C version in the QEMU tree.
> > +The C version will still accept fixes and patches that
> > +are already in development for the moment.
> 
> Just to be clear, 'deprecation' is usually expected to turn into
> 'deletion' a minimum of 2 releases later.  We are targetting the
> C virtiofsd to be deleted, right ?  The last sentance here gives
> vibes that we're expecting it to stick around despite deprecation.

I am targeting it to be deleted, but I'm expecting to give it a bit
more time than 2 releases; how do I do that?

> Assuming we're deleting it after deprecation, then I think thue
> message should be more direct in telling people they shold be
> proactively switching to deployment of the rust version. Something
> along lines of
> 
>   "The C implementation is in maintenance mode only and will
>    be deleted once the deprecation period is complete. New
>    deployments of virtiofs are strongly recommended to switch
>    to use of the Rust implementation of virtiofsd, which is
>    a drop in replacement will compatible command line and
>    featureset."

Yeh, I'll rework it in that direction; I was trying to be gentle at
first.

Dave

> 
> Regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK