[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] hw/i386: Improve bounds checking in OVMF table parsin
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 1/2] hw/i386: Improve bounds checking in OVMF table parsing |
Date: |
Tue, 22 Feb 2022 09:23:59 +0000 |
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Tue, Feb 22, 2022 at 07:19:05AM +0000, Dov Murik wrote:
> When pc_system_parse_ovmf_flash() parses the optional GUIDed table in
> the end of the OVMF flash memory area, the table length field is checked
> for sizes that are too small, but doesn't error on sizes that are too
> big (bigger than the flash content itself).
>
> Add a check for maximal size of the OVMF table, and add an error report
> in case the size is invalid. In such a case, an error like this will be
> displayed during launch:
>
> qemu-system-x86_64: OVMF table has invalid size 4047
>
> and the table parsing is skipped.
>
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
> hw/i386/pc_sysfw_ovmf.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|