[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] hw/i386: Replace magic number with field length calcu
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 2/2] hw/i386: Replace magic number with field length calculation |
|
Date: |
Tue, 22 Feb 2022 09:25:11 +0000 |
|
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Tue, Feb 22, 2022 at 07:19:06AM +0000, Dov Murik wrote:
> Replce the literal magic number 48 with length calculation (32 bytes at
> the end of the firmware after the table footer + 16 bytes of the OVMF
> table footer GUID).
>
> No functional change intended.
>
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
> hw/i386/pc_sysfw_ovmf.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|