Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

[Paolo Bonzini]

On 2/24/22 18:04, Marc-André Lureau wrote:
> Paolo,
>
> This patch is ok, but in some (new?) circumstances it fails with freebsd 
> and reveals that -lutil was missing for kinfo_getproc() in 
> util/oslib-posix.c. Please add:
>
> -util_ss.add(when: 'CONFIG_POSIX', if_true: files('oslib-posix.c'))
> +util_ss.add(when: 'CONFIG_POSIX', if_true: [files('oslib-posix.c'), util])
>
> (even better if we made this specific to freebsd I guess, but not 
> strictly necessary)

Looking again at the patch (because indeed it broke CI :)), I'm not sure 
it's a good idea.  The code seems to be partly taken from other projects 
and doesn't follow the QEMU coding standards.

Paolo