Re: [PATCH] 9pfs: move qemu_dirent_dup() from osdep -> 9p-util

[Peter Maydell]

On Wed, 2 Mar 2022 at 14:16, Christian Schoenebeck
<qemu_oss@crudebyte.com> wrote:
>
> On Dienstag, 1. März 2022 22:59:43 CET Peter Maydell wrote:
> > On Tue, 1 Mar 2022 at 20:47, Christian Schoenebeck
> >
> > <qemu_oss@crudebyte.com> wrote:
> > > Function qemu_dirent_dup() is currently only used by 9pfs server, so move
> > > it from project global header osdep.h to 9pfs specific header 9p-util.h.
> > >
> > > Link:
> > > https://lore.kernel.org/qemu-devel/CAFEAcA_=HAUNomKD2wurSVaAHa5mrk22A1oHK
> > > LWUDjk7v6Khmg@mail.gmail.com/ Based-on:
> > > <20220227223522.91937-12-wwcohen@gmail.com>
> > > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > > ---

> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > since it's just code movement, but those "@c"s look a bit weird:
> > are they really valid kerneldoc comment markup?

> You are right, that's Doxygen format, not kerneldoc format.
>
> If you don't mind I send a separate, subsequent patch that just wipes the
> "@c"s away, and leave this patch as-is (as this one is pure refactoring).

Yes, I agree that should be a separate patch, and just removing
the formatting is the simplest approach.

thanks
-- PMM