[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] hw/usb/redirect.c: Stop using qemu_oom_check()
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 1/9] hw/usb/redirect.c: Stop using qemu_oom_check() |
|
Date: |
Wed, 2 Mar 2022 17:03:33 +0000 |
On Wed, 2 Mar 2022 at 16:31, Eric Blake <eblake@redhat.com> wrote:
> Is exit(EXIT_FAILURE) worth using in this file? We have an
> inconsistent history of a magic number vs. a named constant, so either
> way,
I'm not a huge fan of EXIT_FAILURE, I think it tends to
obscure more than it helps. We have rather more 'exit(1)'
than 'exit(EXIT_FAILURE)' in the codebase.
-- PMM